refactor(Topology): redefine Topology.IsQuotientMap with Topology.IsCoinducing#36957
refactor(Topology): redefine Topology.IsQuotientMap with Topology.IsCoinducing#36957chrisflav wants to merge 6 commits intoleanprover-community:masterfrom
Topology.IsQuotientMap with Topology.IsCoinducing#36957Conversation
PR summary f2fa93365eImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| @@ -289,12 +337,11 @@ protected theorem continuous_iff (hf : IsQuotientMap f) : Continuous g ↔ Conti | |||
| protected theorem continuous (hf : IsQuotientMap f) : Continuous f := | |||
| hf.continuous_iff.mp continuous_id | |||
|
|
|||
| protected lemma isOpen_preimage (hf : IsQuotientMap f) {s : Set Y} : IsOpen (f ⁻¹' s) ↔ IsOpen s := | |||
| ((isQuotientMap_iff.1 hf).2 s).symm | |||
| @[deprecated (since := "2026-03-21")] | |||
| alias isOpen_preimage := IsCoinducing.isOpen_preimage | |||
|
|
|||
| protected theorem isClosed_preimage (hf : IsQuotientMap f) {s : Set Y} : | |||
| IsClosed (f ⁻¹' s) ↔ IsClosed s := | |||
| ((isQuotientMap_iff_isClosed.1 hf).2 s).symm | |||
| @[deprecated (since := "2026-03-21")] | |||
| alias isClosed_preimage := IsCoinducing.isClosed_preimage | |||
There was a problem hiding this comment.
It seems to me that these being deprecated is the cause of a lot of changing h.isOpen_preimage to h.isCoinducing.isOpen_preimage, where if these didn't exist instead then h.isOpen_preimage would just work. In this case might we consider not deprecating instead, since it would only break explicit references to IsQuotientMap.isOpen_preimage, which should be rarer since it is usually used with the dot notation?
There was a problem hiding this comment.
I had considered this, but eventually decided against it. Not deprecating brings only little benefit. The changes are all straightforward and while h.isCoinducing.isOpen_preimage is slightly worse, it is not bad either.
Currently, varying formulations for
f : X -> Yis coinducing are used: Examples are an equality ofTopologicalSpace.coinducedor an explicit characterization of open sets.We add a predicate
Topology.IsCoinducingand redefineTopology.IsQuotientMapin terms of it.