Skip to content

refactor(Topology): redefine Topology.IsQuotientMap with Topology.IsCoinducing#36957

Open
chrisflav wants to merge 6 commits intoleanprover-community:masterfrom
chrisflav:iscoinducing
Open

refactor(Topology): redefine Topology.IsQuotientMap with Topology.IsCoinducing#36957
chrisflav wants to merge 6 commits intoleanprover-community:masterfrom
chrisflav:iscoinducing

Conversation

@chrisflav
Copy link
Member

@chrisflav chrisflav commented Mar 21, 2026

Currently, varying formulations for f : X -> Y is coinducing are used: Examples are an equality of TopologicalSpace.coinduced or an explicit characterization of open sets.
We add a predicate Topology.IsCoinducing and redefine Topology.IsQuotientMap in terms of it.


Open in Gitpod

@chrisflav chrisflav added WIP Work in progress t-topology Topological spaces, uniform spaces, metric spaces, filters labels Mar 21, 2026
@github-actions
Copy link

github-actions bot commented Mar 21, 2026

PR summary f2fa93365e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsCoinducing
+ Topology.IsCoinducing.image_connectedComponent
+ Topology.IsCoinducing.preimage_connectedComponent
+ Topology.IsCoinducing.restrictPreimage_of_isOpen
+ comp
+ continuous
+ id
+ isCoinducing_iff
+ isCoinducing_iff_isClosed
+ of_comp
+ of_comp_of_continuous
+ of_comp_of_isCoinducing
+ of_isClosed_preimage_iff_isClosed
+ of_isOpen_preimage_iff_isOpen
++- isClosed_preimage
++- isOpen_preimage
- isQuotientMap_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@chrisflav chrisflav added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed WIP Work in progress labels Mar 21, 2026
Comment on lines 292 to +344
@@ -289,12 +337,11 @@ protected theorem continuous_iff (hf : IsQuotientMap f) : Continuous g ↔ Conti
protected theorem continuous (hf : IsQuotientMap f) : Continuous f :=
hf.continuous_iff.mp continuous_id

protected lemma isOpen_preimage (hf : IsQuotientMap f) {s : Set Y} : IsOpen (f ⁻¹' s) ↔ IsOpen s :=
((isQuotientMap_iff.1 hf).2 s).symm
@[deprecated (since := "2026-03-21")]
alias isOpen_preimage := IsCoinducing.isOpen_preimage

protected theorem isClosed_preimage (hf : IsQuotientMap f) {s : Set Y} :
IsClosed (f ⁻¹' s) ↔ IsClosed s :=
((isQuotientMap_iff_isClosed.1 hf).2 s).symm
@[deprecated (since := "2026-03-21")]
alias isClosed_preimage := IsCoinducing.isClosed_preimage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that these being deprecated is the cause of a lot of changing h.isOpen_preimage to h.isCoinducing.isOpen_preimage, where if these didn't exist instead then h.isOpen_preimage would just work. In this case might we consider not deprecating instead, since it would only break explicit references to IsQuotientMap.isOpen_preimage, which should be rarer since it is usually used with the dot notation?

Copy link
Member Author

@chrisflav chrisflav Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had considered this, but eventually decided against it. Not deprecating brings only little benefit. The changes are all straightforward and while h.isCoinducing.isOpen_preimage is slightly worse, it is not bad either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants