Skip to content

feat: add missing IndiscreteTopology instances#36968

Open
NoahW314 wants to merge 1 commit intoleanprover-community:masterfrom
NoahW314:IndiscreteTopology
Open

feat: add missing IndiscreteTopology instances#36968
NoahW314 wants to merge 1 commit intoleanprover-community:masterfrom
NoahW314:IndiscreteTopology

Conversation

@NoahW314
Copy link
Contributor

Add several instances for the IndiscreteTopology. These instances are chosen as they have short proofs and imply many of the more common instances like NormalSpace and LocPathConnectedSpace.


Open in Gitpod

Add several instances for the indiscreteTopology.  These instances were chosen as they are easy to prove and imply many of the more common instances like `NormalSpace` and `LocPathConnectedSpace`.
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 22, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link

PR summary a499e40942

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IndiscreteTopology.toAlexandrovDiscrete
+ Pi.indiscreteTopology
+ Prod.indiscreteTopology
+ instance (priority := 100) IndiscreteTopology.pseudoMetrizableSpace [IndiscreteTopology X] :
+ instance (priority := 100) [IndiscreteTopology X] : PreirreducibleSpace X

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants