[Merged by Bors] - refactor(Analysis/Convex/Cone/InnerDual): remove duplicate proof of hyperplane separation

[artie2000]

• Deprecate ConvexCone.hyperplane_separation_of_nonempty_of_isClosed_of_notMem in favour of ProperCone.hyperplane_separation', which has identical content.

---

[github-actions]

PR summary 34ea11a4a8

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff

- ConvexCone.hyperplane_separation_of_nonempty_of_isClosed_of_notMem

You can run this locally as follows

## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

---

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[artie2000]

I think this builds on the idea in #24149 - I don't know why this duplicate declaration was kept then.

[YaelDillies]

Thanks! 🚀

maintainer merge

[github-actions]

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

---

pull_request_review, wf_run

[YaelDillies]

I think this builds on the idea in #24149 - I don't know why this duplicate declaration was kept then.

I wasn't yet sure how strongly we wanted to avoid ConvexCone. I now feel it is "quite strongly".

[ocfnash]

Thanks!

bors merge

[mathlib-bors]

Pull request successfully merged into master.

Build succeeded:

• ci (staging) / Post-Build Step
• ci (staging) / Lint style
• ci (staging) / Build
• ci (staging) / Post-CI job