Skip to content

chore(Data/Finset/Lattice/Fold): rename comp_sup_* to apply_sup_*#37185

Open
gasparattila wants to merge 5 commits intoleanprover-community:masterfrom
gasparattila:comp-sup-rename
Open

chore(Data/Finset/Lattice/Fold): rename comp_sup_* to apply_sup_*#37185
gasparattila wants to merge 5 commits intoleanprover-community:masterfrom
gasparattila:comp-sup-rename

Conversation

@gasparattila
Copy link
Contributor

These lemmas are of the form g (s.sup f) = s.sup (g ∘ f) with no composition on the LHS.


Open in Gitpod

This PR uses the `@[to_dual]` attribute to generate dual lemmas about `Finset.sup`. The lemmas about `sdiff` and `himp` are skipped, as `HeytingAlgebra` is not yet tagged with `@[to_dual]`.

Other changes:
- tag `inf_insert` with `@[grind =]`
- rename `le_inf_const_le` to `le_inf_const`
- tag `inf_union` with `@[grind _=_]`
- tag `inf_mono_fun` with `@[grind ←]`
- tag `inf_mono` with `@[grind ←]`
- tag `inf_attach` with `@[simp]`
- add `le_inf_of_directed_le`
- add `inf_eq_top_of_isEmpty`
- add `inf_mem_of_nonempty`
- rename `comp_sup_eq_sup_comp_of_is_total` to `comp_sup_eq_sup_comp_of_linearOrder` (and similarly for the `inf` version)
- add `inf'_mono_fun`
- add `comp_inf_eq_inf_comp_of_nonempty`
@github-actions
Copy link

github-actions bot commented Mar 25, 2026

PR summary 49ba224813

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ apply_sup'_eq_sup'_comp
+ apply_sup_eq_sup_comp
+ apply_sup_eq_sup_comp_of_linearOrder
+ apply_sup_eq_sup_comp_of_nonempty
- Nonempty.inf_eq_bot_iff
- _root_.List.foldr_inf_eq_inf_toFinset
- _root_.map_finset_inf
- _root_.map_finset_inf'
- codisjoint_inf_left
- codisjoint_inf_right
- coe_inf'
- coe_inf_of_nonempty
- compl_inf
- exists_inf_eq_iInf
- exists_inf_le
- exists_mem_eq_inf
- exists_mem_eq_inf'
- inf
- inf'
- inf'_apply
- inf'_comm
- inf'_comp_eq_image
- inf'_comp_eq_map
- inf'_congr
- inf'_cons
- inf'_const
- inf'_eq_inf
- inf'_eq_of_forall
- inf'_image
- inf'_induction
- inf'_insert
- inf'_le
- inf'_le_iff
- inf'_le_of_le
- inf'_lt_iff
- inf'_map
- inf'_mem
- inf'_mono
- inf'_singleton
- inf'_sup_distrib_left
- inf'_sup_distrib_right
- inf'_union
- inf_apply
- inf_attach
- inf_coe
- inf_comm
- inf_congr
- inf_cons
- inf_const
- inf_def
- inf_disjSum
- inf_dite_neg_le
- inf_dite_pos_le
- inf_empty
- inf_eq_bot_iff
- inf_eq_iInf
- inf_eq_sInf_image
- inf_eq_top_iff
- inf_erase_top
- inf_id_eq_sInf
- inf_image
- inf_induction
- inf_inf
- inf_insert
- inf_ite
- inf_le
- inf_le_iff
- inf_le_of_le
- inf_lt_iff
- inf_map
- inf_mem
- inf_mono
- inf_mono_fun
- inf_of_mem
- inf_singleton
- inf_sup_distrib_left
- inf_sup_distrib_right
- inf_top
- inf_union
- isGLB_inf
- isGLB_inf'
- isGLB_inf_id
- le_inf'_iff
- le_inf_iff
- lt_inf'_iff
- lt_inf_iff
- ofDual_inf
- ofDual_inf'
- toDual_inf
- toDual_inf'

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
8395 -2 backward.isDefEq

Current commit 1245092d60
Reference commit 49ba224813

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 25, 2026
@mathlib-dependent-issues
Copy link

This PR/issue depends on:

These lemmas are of the form `g (s.sup f) = s.sup (g ∘ f)` with no composition on the LHS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant