Skip to content

chore(Algebra/Order): bound on |n / m|ₘ and |n - m|#37232

Open
mathlib-splicebot[bot] wants to merge 1 commit intomasterfrom
splice-bot/pr-34722-Mathlib-Algebra-Order-Group-Unbundled-Abs.lean-05cfa3ba4a-d1hl4x4
Open

chore(Algebra/Order): bound on |n / m|ₘ and |n - m|#37232
mathlib-splicebot[bot] wants to merge 1 commit intomasterfrom
splice-bot/pr-34722-Mathlib-Algebra-Order-Group-Unbundled-Abs.lean-05cfa3ba4a-d1hl4x4

Conversation

@mathlib-splicebot
Copy link
Copy Markdown
Contributor

This PR was automatically created from PR #34722 by @GrigorenkoPV via a review comment by @Vierkantor.

@github-actions
Copy link
Copy Markdown

PR summary 0f8bcdff02

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ abs_div_lt_of_lt_lt

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 26, 2026
@Vierkantor Vierkantor changed the title chore(Mathlib/Algebra/Order/Group/Unbundled/Abs.lean): automated extraction chore(Algebra/Order): bound on |n / m| Mar 26, 2026
@Vierkantor Vierkantor changed the title chore(Algebra/Order): bound on |n / m| chore(Algebra/Order): bound on |n / m| Mar 26, 2026
@Vierkantor Vierkantor changed the title chore(Algebra/Order): bound on |n / m| chore(Algebra/Order): bound on |n / m|ₘ and |n - m| Mar 26, 2026
@[to_additive] lemma max_div_min_eq_mabs (a b : α) : max a b / min a b = |b / a|ₘ := by
rw [mabs_div_comm, max_div_min_eq_mabs']

@[to_additive] lemma abs_div_lt_of_lt_lt {N M n m : α} (hn : 1 ≤ n) (hm : 1 ≤ m) (hnN : n < N)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused for a moment until I saw that this was mabs, not abs. Let's clarify the name:

Suggested change
@[to_additive] lemma abs_div_lt_of_lt_lt {N M n m : α} (hn : 1 ≤ n) (hm : 1 ≤ m) (hnN : n < N)
@[to_additive] lemma mabs_div_lt_of_lt_lt {N M n m : α} (hn : 1 ≤ n) (hm : 1 ≤ m) (hnN : n < N)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't think @GrigorenkoPV will have permission to accept the suggestion, since the PR was created by a bot.

Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 26, 2026

✌️ mathlib-splicebot[bot] can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 26, 2026
@bryangingechen
Copy link
Copy Markdown
Contributor

@Vierkantor I'm guessing you didn't mean to delegate to the bot?

@Vierkantor
Copy link
Copy Markdown
Contributor

I'm guessing you didn't mean to delegate to the bot?

Ah oops! Yes, I did not take into account how GitHub's interface factors into this... @GrigorenkoPV I suppose if you agree with the change then I'll apply it and merge this PR myself using maintainer powers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants