feat: TryThis suggestion for the mergeWithGrind linter#37236
Open
chenson2018 wants to merge 1 commit intoleanprover-community:masterfrom
Open
feat: TryThis suggestion for the mergeWithGrind linter#37236chenson2018 wants to merge 1 commit intoleanprover-community:masterfrom
TryThis suggestion for the mergeWithGrind linter#37236chenson2018 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary c551257516Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
joneugster
reviewed
Mar 29, 2026
| if let some stop := postI.tacI.stx.getTailPos? then | ||
| let synth := Lean.Syntax.setInfo (Lean.SourceInfo.synthetic start stop) preI.tacI.stx | ||
| Elab.Command.liftCoreM <| | ||
| Tactic.TryThis.addSuggestion (header := header) synth (← `(tactic | grind)) |
Contributor
There was a problem hiding this comment.
Did you verify none of the tooling relies on the linter warnings to be logWarnings instead of logInfos?
Contributor
Author
There was a problem hiding this comment.
Yes, this is what I was trying to describe in the PR description, apologies if that was unclear. To my knowledge the only workflow that uses this option is weekly-lints.yml, which in using zulip_build_report.sh should report either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
mergeWithGrindlinter to provide aTryThissuggestion. The same message is provided as the currently logged warning, and should still be processed properly byzulip_build_report.shduring the weekly linting, just underinfoinstead ofwarning.The motivation here (discussed in #general > automatically apply code actions) is that following #36712 we should be able to partially automate the weekly linting PRs using Skimmer. As an example, the changes in #37018 were prepared in part in this way.