refactor(Order/OmegaCompletePartialOrder): make Chain a structure#37258
refactor(Order/OmegaCompletePartialOrder): make Chain a structure#37258YaelDillies wants to merge 6 commits intoleanprover-community:masterfrom
Chain a structure#37258Conversation
It has a different `LE` to `OrderHom`, hence should not be an `abbrev`.
PR summary 00fca21215Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
vihdzp
left a comment
There was a problem hiding this comment.
This mostly looks good, just some questions/comments.
| lemma directed : Directed (· ≤ ·) c := directedOn_range.2 c.isChain_range.directedOn | ||
|
|
||
| /-- `map` function for `Chain` -/ | ||
| -- Not `@[simps]`: we need `@[simps!]` to see through the type synonym `Chain β = ℕ →o β`, |
There was a problem hiding this comment.
Is this comment still relevant? If not, why not use simps here?
There was a problem hiding this comment.
No, it isn't relevant anymore because simps! can't see through Chain anymore. I can't use simps here because it generates an _apply lemma instead of a coe_ one, which is what's needed further down. I know about simps -isApplied but unfortunately simps doesn't know that this should change the name from _apply to coe_. Feel free to open an issue about this.
It has a different
LEtoOrderHom, hence should not be anabbrev.