Skip to content

chore: deprecate Ordinal.iSup_typein_succ and Ordinal.iSup_typein_limit#37261

Open
vihdzp wants to merge 78 commits intoleanprover-community:masterfrom
vihdzp:lsubstart
Open

chore: deprecate Ordinal.iSup_typein_succ and Ordinal.iSup_typein_limit#37261
vihdzp wants to merge 78 commits intoleanprover-community:masterfrom
vihdzp:lsubstart

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Mar 27, 2026

Both are very convoluted ways to write down sSup (Iic o) = o or sSup (Iio o) = o.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary d9deee6132

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ aleph_one_le_iff
+ cof_omega_one
+ lift_eq_omega_one
+ lift_le_omega_one
+ lift_lt_omega_one
+ lt_aleph_one_iff
+ omega_one_eq_lift
+ omega_one_le_lift
+ omega_one_lt_lift
+ range_eq
+ range_eq_Iio
- card_mem_cof

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (3.00, 0.19)
Current number Change Type
16 3 disabled deprecation lints

Current commit cb88eb71fa
Reference commit d9deee6132

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp mentioned this pull request Mar 27, 2026
2 tasks
@vihdzp vihdzp added the t-set-theory Set theory label Mar 27, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 27, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 27, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant