Skip to content

chore(RepresentationTheory/FiniteIndex): generalize universes#37271

Open
Whysoserioushah wants to merge 6 commits intoleanprover-community:masterfrom
Whysoserioushah:edison/rep5
Open

chore(RepresentationTheory/FiniteIndex): generalize universes#37271
Whysoserioushah wants to merge 6 commits intoleanprover-community:masterfrom
Whysoserioushah:edison/rep5

Conversation

@Whysoserioushah
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

PR summary d0376242cf

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 27, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 27, 2026

Benchmark results for 26b3d4a against 55b0702 are in. Significant changes detected! @riccardobrasca @robin-carlier

  • 🟥 build//instructions: +13.8G (+0.01%)

Large changes (1🟥)

  • 🟥 build/module/Mathlib.RepresentationTheory.FiniteIndex//instructions: +30.2G (+53.92%)

Small changes (1✅)

  • build/module/Mathlib.RingTheory.TwoSidedIdeal.Kernel//instructions: -615.3M (-9.45%)

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 27, 2026
@Whysoserioushah Whysoserioushah removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 29, 2026
@Whysoserioushah
Copy link
Copy Markdown
Collaborator Author

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 29, 2026

Benchmark results for b92e1d0 against 9f0aee2 are in. Significant changes detected! @Whysoserioushah

  • 🟥 build//instructions: +32.0G (+0.02%)

Large changes (1🟥)

  • 🟥 build/module/Mathlib.RepresentationTheory.FiniteIndex//instructions: +30.5G (+54.57%)

@riccardobrasca
Copy link
Copy Markdown
Member

The biggest slowdown seems to be in resIndAdjunction_unit_app. Looking at the trace I still see

[Meta.isDefEq] [17940362.000000] ❌️ (𝟭 (Rep.{max ?u.140033 u v, u, v} k G)).obj B ⟶
              (resFunctor S.subtype ⋙ indFunctor k S.subtype).obj
                B =?= (𝟭 (Rep.{max v w u, u, v} k G)).obj B ⟶ ind S.subtype (res S.subtype B)

Can we get rid of universe 140033?

@riccardobrasca
Copy link
Copy Markdown
Member

!radar

@riccardobrasca
Copy link
Copy Markdown
Member

I gave a try, let's see.

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 30, 2026

Benchmark results for 2bd7083 against d037624 are in. Significant changes detected! @riccardobrasca

  • 🟥 main exited with code 1

No significant changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants