ci: remove special support for ProofWidgets4 cloud releases#37286
ci: remove special support for ProofWidgets4 cloud releases#37286Vtec234 wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
PR summary 34f85c5f24Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
|
bors try |
…7286) This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
|
|
||
| echo "✅ ProofWidgets source URL is allowed: $proofwidgets_url" | ||
|
|
||
| - name: verify ProofWidgets lean-toolchain matches on versioned releases |
There was a problem hiding this comment.
This was introduced in #31723. We no longer need to pin ProofWidgets4 to a specific tagged version after this PR. Indeed, all the other dependencies are required as main. But actually using a tagged version seems like good practice. So I see two options:
- Keep
require proofwidgetsat a tagged version, and keep this CI check. - Use
main, remove the CI check.
There was a problem hiding this comment.
Hm, actually this seems to duplicate functionality of verify_proofwidgets_toolchain in scripts/verify_version_tags.py. But there are no references to that script (only meant to be run locally? introduced in #32162).
|
Superseded by #37290. |
This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
Branch on this repo to exercise the CI: https://github.com/leanprover-community/mathlib4/tree/rm-pw4-cache .