Skip to content

[Merged by Bors] - chore(Topology/Sets/Compacts): use fast_instance%#37348

Closed
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-Compacts-instances
Closed

[Merged by Bors] - chore(Topology/Sets/Compacts): use fast_instance%#37348
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-Compacts-instances

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

Using fast_instance% here should remove some diamonds.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary e885514426

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : OrderBot (CompactOpens α)
- instance : OrderBot (CompactOpens α) := OrderBot.lift ((↑) : _ → Set α) (fun _ _ => id) coe_bot

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 30, 2026
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 30, 2026

What could possibly go wrong?
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.


issue_comment, wf_run

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 30, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Mar 30, 2026

Benchmark results for f7987e8 against e885514 are in. There are no significant changes. @riccardobrasca

  • 🟥 build//instructions: +2.4G (+0.00%)

Small changes (1✅, 2🟥)

  • 🟥 build/module/Mathlib.RingTheory.DividedPowerAlgebra.Init//instructions: +318.0M (+1.77%)
  • build/module/Mathlib.Tactic.Widget.SelectInsertParamsClass//instructions: -412.2M (-12.06%)
  • 🟥 build/module/Mathlib.Util.FormatTable//instructions: +135.4M (+4.56%)

@sgouezel
Copy link
Copy Markdown
Contributor

bors r+

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 30, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 30, 2026
Using `fast_instance%` here should remove some diamonds.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 30, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology/Sets/Compacts): use fast_instance% [Merged by Bors] - chore(Topology/Sets/Compacts): use fast_instance% Mar 30, 2026
@mathlib-bors mathlib-bors bot closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants