Skip to content

feat(RingTheory): refactor smulShortComplex#37355

Open
Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
Thmoas-Guan:refactor-smulShortComplex
Open

feat(RingTheory): refactor smulShortComplex#37355
Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
Thmoas-Guan:refactor-smulShortComplex

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

Use LinearMap.lsmul for the f of ModuleCat.smulShortComplex, also providing new APIs for it.


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Mar 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

PR summary 2da3b35b9d

Import changes exceeding 2%

% File
+33.54% Mathlib.RingTheory.Regular.Category

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Regular.Category 1479 1975 +496 (+33.54%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Regular.Category 496

Declarations diff

+ Ext.smulShortComplex_f_postcomp_eq_zero_of_mem_ann
+ Ext.smul_id_postcomp_eq_zero_of_mem_ann
+ LinearMap.exact_lsmul_smul_top_mkQ
+ smulShortComplex_f_eq_smul_id
+ smulShortComplex_f_hom_eq_smul_id
- LinearMap.exact_smul_id_smul_top_mkQ

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6889 1 backward.isDefEq

Current commit e4b1a57871
Reference commit 2da3b35b9d

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant