feat(RingTheory): refactor smulShortComplex#37355
Open
Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
Open
feat(RingTheory): refactor smulShortComplex#37355Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
smulShortComplex#37355Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 2da3b35b9dImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Regular.Category | 1479 | 1975 | +496 (+33.54%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Regular.Category |
496 |
Declarations diff
+ Ext.smulShortComplex_f_postcomp_eq_zero_of_mem_ann
+ Ext.smul_id_postcomp_eq_zero_of_mem_ann
+ LinearMap.exact_lsmul_smul_top_mkQ
+ smulShortComplex_f_eq_smul_id
+ smulShortComplex_f_hom_eq_smul_id
- LinearMap.exact_smul_id_smul_top_mkQ
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 6889 | 1 | backward.isDefEq |
Current commit e4b1a57871
Reference commit 2da3b35b9d
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This reverts commit b6fa447.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
LinearMap.lsmulfor thefofModuleCat.smulShortComplex, also providing new APIs for it.