Skip to content

[Merged by Bors] - chore: golf using simp#37458

Closed
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
euprunin:golf-dcxlii
Closed

[Merged by Bors] - chore: golf using simp#37458
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
euprunin:golf-dcxlii

Conversation

@euprunin
Copy link
Copy Markdown
Contributor

The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (differences <30 ms considered measurement noise):

  • ✅️ MvPolynomial.coeff_sum_X_pow_of_fintype: 430 ms before, 101 ms after 🎉
  • ✅️ CategoryTheory.Functor.Monoidal.associator_hom_app: 59 ms before, <30 ms after 🎉
  • ✅️ Height.mulHeight₁_div_eq_mulHeight: unchanged 🎉
  • ✅️ Ordinal.nfp_add_zero: unchanged 🎉

Profiled using set_option trace.profiler true in.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary b6118399e6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg self-assigned this Mar 31, 2026
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Mar 31, 2026

Thanks!
bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 31, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 31, 2026
The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (differences <30 ms considered measurement noise):
* `✅️ MvPolynomial.coeff_sum_X_pow_of_fintype`: 430 ms before, 101 ms after  🎉
* `✅️ CategoryTheory.Functor.Monoidal.associator_hom_app`: 59 ms before, <30 ms after  🎉
* `✅️ Height.mulHeight₁_div_eq_mulHeight`: unchanged 🎉
* `✅️ Ordinal.nfp_add_zero`: unchanged 🎉

Profiled using `set_option trace.profiler true in`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 31, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: golf using simp [Merged by Bors] - chore: golf using simp Mar 31, 2026
@mathlib-bors mathlib-bors bot closed this Mar 31, 2026
aditya-ramabadran pushed a commit to aditya-ramabadran/mathlib4 that referenced this pull request Apr 1, 2026
The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (differences <30 ms considered measurement noise):
* `✅️ MvPolynomial.coeff_sum_X_pow_of_fintype`: 430 ms before, 101 ms after  🎉
* `✅️ CategoryTheory.Functor.Monoidal.associator_hom_app`: 59 ms before, <30 ms after  🎉
* `✅️ Height.mulHeight₁_div_eq_mulHeight`: unchanged 🎉
* `✅️ Ordinal.nfp_add_zero`: unchanged 🎉

Profiled using `set_option trace.profiler true in`.
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (differences <30 ms considered measurement noise):
* `✅️ MvPolynomial.coeff_sum_X_pow_of_fintype`: 430 ms before, 101 ms after  🎉
* `✅️ CategoryTheory.Functor.Monoidal.associator_hom_app`: 59 ms before, <30 ms after  🎉
* `✅️ Height.mulHeight₁_div_eq_mulHeight`: unchanged 🎉
* `✅️ Ordinal.nfp_add_zero`: unchanged 🎉

Profiled using `set_option trace.profiler true in`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants