Skip to content

feat: add some missing convenience lemmas about ordered modules#37709

Open
j-loreaux wants to merge 1 commit intoleanprover-community:masterfrom
j-loreaux:nonneg_of_smul_nonneg
Open

feat: add some missing convenience lemmas about ordered modules#37709
j-loreaux wants to merge 1 commit intoleanprover-community:masterfrom
j-loreaux:nonneg_of_smul_nonneg

Conversation

@j-loreaux
Copy link
Copy Markdown
Contributor


Open in Gitpod

@j-loreaux j-loreaux added the t-algebra Algebra (groups, rings, fields, etc) label Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

PR summary 35186be320

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ nonneg_of_smul_nonneg_of_pos_left
+ nonneg_of_smul_nonneg_of_pos_right
+ nonpos_of_smul_nonpos_of_pos_left
+ nonpos_of_smul_nonpos_of_pos_right
+ smul_nonneg_iff_nonneg_of_pos_left
+ smul_nonneg_iff_nonneg_of_pos_right
+ smul_nonpos_iff_nonpos_of_pos_left
+ smul_nonpos_iff_nonpos_of_pos_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen
Copy link
Copy Markdown
Collaborator

Some of these seem like they could be good grind lemmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants