Skip to content

[Merged by Bors] - fix(FieldTheory/Galois/Basic): inferInstance instance should be a theorem#37822

Closed
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
SnirBroshi:patch-3
Closed

[Merged by Bors] - fix(FieldTheory/Galois/Basic): inferInstance instance should be a theorem#37822
SnirBroshi wants to merge 1 commit intoleanprover-community:masterfrom
SnirBroshi:patch-3

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

Corrects a mistake I made in #37448


I think this is bad, although I'm not sure.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR summary eee511dba0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 9, 2026
@adomani
Copy link
Copy Markdown
Contributor

adomani commented Apr 9, 2026

Thanks: definitely deprecated instances seem a bad idea! I should have picked this up during review.

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 9, 2026
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 9, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 9, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(FieldTheory/Galois/Basic): inferInstance instance should be a theorem [Merged by Bors] - fix(FieldTheory/Galois/Basic): inferInstance instance should be a theorem Apr 9, 2026
@mathlib-bors mathlib-bors bot closed this Apr 9, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants