perf(Data/Complex/Basic): no_expose the Inv and Norm instance#38007
perf(Data/Complex/Basic): no_expose the Inv and Norm instance#38007JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
no_expose the Inv and Norm instance#38007Conversation
PR summary 03ab904979Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
no_expose the Inv instanceno_expose the Inv instance
|
(@grunweg, did you actually change the title? I just see the same title before and after?) |
|
!bench |
|
Benchmark results for 33d46ee against 03ab904 are in. No significant results found. @JovanGerb
Small changes (1✅)
|
|
I fixed a typo "Comlex" :-) |
|
I tried putting So, the only one that I ended up keeping is However, I already cleaned up some proofs that were abusing defeq, and I think we may as well take these cleaned up proofs now that I made them, so I've left them in this PR. |
no_expose the Inv instanceno_expose the Inv and Norm instance
This PR hides some more implementation details of complex numbers.
It would be possible to
no_exposeeven more definitions, but this could be at the cost of some proof writing convenience.