Skip to content

feat(push): error message tweaks#38008

Open
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:atlocation-message-tweaks
Open

feat(push): error message tweaks#38008
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:atlocation-message-tweaks

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 13, 2026

  • make declaration names in all errors "made no progress" hoverable (this applies also to ring, abel, field_simp, ...)
  • include the constant being pushed in the error message

Open in Gitpod

grunweg added 4 commits April 13, 2026 15:18
Make errors in AtLocation surround the tactic name with backticks by default.
This fixes a few error messages to comply with mathlib's style guide.

Extracted from leanprover-community#37899.
logWarning does most of the heavy listing (by adding the necessary message
context), so this was very easy.

Also add a test for the current push_neg error if no progress was made.
Making it print the constant pushed would be more readable (but that is
not as obvious).
@grunweg grunweg added the t-meta Tactics, attributes or user commands label Apr 13, 2026
@grunweg grunweg requested a review from thorimur April 13, 2026 15:31
@github-actions
Copy link
Copy Markdown

PR summary 0b45e1648d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 13, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant