refactor: golf only Function/SimpleFunc, Function/LpSeminorm/Basic, Constructions/Polish/Basic#38107
Open
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Open
refactor: golf only Function/SimpleFunc, Function/LpSeminorm/Basic, Constructions/Polish/Basic#38107yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Function/SimpleFunc, Function/LpSeminorm/Basic, Constructions/Polish/Basic#38107yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 8e3c989104Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
t-measure-probability
grunweg
reviewed
Apr 16, 2026
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
A couple of minor comments. Can you comment on the performance aspects of this change?
| have : ∀ᵐ x ∂μ, ‖f x‖₊ ≤ ‖(C : ℝ)‖₊ := hfC.mono fun x hx => hx.trans_eq C.nnnorm_eq.symm | ||
| refine (eLpNorm_mono_ae this).trans_eq ?_ | ||
| rw [eLpNorm_const _ hp (NeZero.ne μ), C.enorm_eq, one_div, ENNReal.smul_def, smul_eq_mul] | ||
| simpa [C.enorm_eq, ENNReal.smul_def, smul_eq_mul] using |
Contributor
There was a problem hiding this comment.
This simpa might be too strongly golfed: can you make this have := ...; simpa [...] instead?
| Set.piecewise_eq_of_notMem _ _ _ hx, _root_.add_left_inj, add_eq_right] using hx | ||
| rw [this] | ||
| exact Measurable.piecewise f.measurableSet_support hf hf' | ||
| simpa using f.measurable_bind (fun b a => b + g a) fun b => hg.const_add b |
| @MeasurableSet.image_of_continuousOn_injOn γ | ||
| _ _ _ _ s f _ t' t'_polish (@borel γ t') (@BorelSpace.mk _ _ (borel γ) rfl) | ||
| M (@Continuous.continuousOn γ _ t' _ f s f_cont) f_inj | ||
| have hs' := (borel_anti t't s) <| by rwa [← eq_borel_upgradeStandardBorel γ] |
Contributor
There was a problem hiding this comment.
You'd have to answer somebody else to review this --- splitting into a separate PR might do.
grunweg
added
the
awaiting-author
EtienneC30
reviewed
Apr 16, 2026
3 tasks
grunweg
added
the
LLM-generated
Contributor
|
Echoing my comment made elsewhere, can you also update the PR description to be more helpful? Thanks! |
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de> Co-authored-by: Etienne Marion <66847262+EtienneC30@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR selectively ports part of #38104.
Included files:
Mathlib/MeasureTheory/Function/SimpleFunc.leanMathlib/MeasureTheory/Function/LpSeminorm/Basic.leanMathlib/MeasureTheory/Constructions/Polish/Basic.leanThis intentionally excludes the rest of #38104.
No build or compile checks were run for this selective port.