Skip to content

chore(GroupTheory/GroupAction/Hom): improve to_additive use#38150

Open
JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-to_additive-MulDistribMulActionHomClass
Open

chore(GroupTheory/GroupAction/Hom): improve to_additive use#38150
JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-to_additive-MulDistribMulActionHomClass

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Apr 17, 2026

This PR cleans up after #34249, replacing some uses of to_additive existing with just to_additive. The fields of MulDistribMulAction had to be reordered in order to align with the additive version DistribMulAction.

This is an adaptation for the overlapping instances linter (#38126)


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

PR summary 05475cac70

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : One (A →*[M] A)
+ instance _root_.DistriMulActionHom.instZero {A : Type*} [AddMonoid A] [DistribMulAction M A]
+ instance {A : Type*} [AddMonoid A] [DistribMulAction M A]
- DistribMulAction.instFunLike
- DistribMulActionHomClass
- _root_.DistribMulActionHom.comp
- _root_.DistribMulActionHom.id
- _root_.DistribMulActionHom.inverse
- _root_.DistribMulActionSemiHomClass.toDistribMulActionHom
- instance [AddMonoid A] [DistribMulAction M A] [AddMonoid B] [DistribMulAction N B] :
- instance [Monoid A] [MulDistribMulAction M A] : One (A →*[M] A)
- instance _root_.DistriMulActionHom.instZero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-group-theory Group theory label Apr 17, 2026
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Comment thread Mathlib/GroupTheory/GroupAction/Hom.lean Outdated
@JovanGerb JovanGerb requested a review from ocfnash April 17, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants