Skip to content

feat: lint against new cases of the backward.inferInstanceAs.wrap.reu…#38152

Open
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:backward-setoption
Open

feat: lint against new cases of the backward.inferInstanceAs.wrap.reu…#38152
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:backward-setoption

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 17, 2026

…seSubInstances option

This marks new technical debt: it should not happen at all (and if it does, disabling the linter explicitly should be a necessary speed bump): zulip discussion


Open in Gitpod

…seSubInstances option

This marks new technical debt: it should not happen at all (and if it does,
disabling the linter explicitly should be a necessary speed bump):
[zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Technical.20Debt.20Counters/near/586058368)
@grunweg grunweg added t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

PR summary 8e3c989104

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-linter Linter label Apr 17, 2026
Comment thread Mathlib/Order/OrderDual.lean Outdated
Comment thread Mathlib/Tactic/Linter/Style.lean Outdated
Co-authored-by: Jovan Gerbscheid <56355248+JovanGerb@users.noreply.github.com>
@JovanGerb
Copy link
Copy Markdown
Contributor

Thanks

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by JovanGerb.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-linter Linter t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants