Skip to content

feat(Algebra/Module/FinitePresentation) : Finitely Presented Module Lemma#38170

Open
maddycrim wants to merge 2 commits intoleanprover-community:masterfrom
maddycrim:FLT_fp
Open

feat(Algebra/Module/FinitePresentation) : Finitely Presented Module Lemma#38170
maddycrim wants to merge 2 commits intoleanprover-community:masterfrom
maddycrim:FLT_fp

Conversation

@maddycrim
Copy link
Copy Markdown
Collaborator

From FLT Project

Main Definitions:

Module.FinitePresentation.exists_fin_exact : A finitely presented module M admits an exact sequence F' -> F -> M -> 0 where F' and F are finite free modules.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 17, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

PR summary 2fa7ed1c4d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ exists_exact_and_surjective

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

error: the PR title should be of the form
  kind: main title
or
  kind(scope): main title
Allowed values for `kind` are [feat, chore, perf, refactor, style, fix, doc, test, ci]
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@maddycrim maddycrim changed the title feat(Algebra/Module/FinitePresentation) - Finitely Presented Module Lemma feat(Algebra/Module/FinitePresentation) : Finitely Presented Module Lemma Apr 17, 2026
Comment thread Mathlib/Algebra/Module/FinitePresentation.lean
Comment thread Mathlib/Algebra/Module/FinitePresentation.lean
Comment thread Mathlib/Algebra/Module/FinitePresentation.lean
Comment thread Mathlib/Algebra/Module/FinitePresentation.lean
Comment thread Mathlib/Algebra/Module/FinitePresentation.lean Outdated
@themathqueen
Copy link
Copy Markdown
Collaborator

I think all changes you made on github reverted when you force-pushed btw. Can you change them again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants