Skip to content

feat(Algebra/MvPolynomial): add monomial prod lemma#38322

Open
NoahW314 wants to merge 1 commit intoleanprover-community:masterfrom
NoahW314:monomial
Open

feat(Algebra/MvPolynomial): add monomial prod lemma#38322
NoahW314 wants to merge 1 commit intoleanprover-community:masterfrom
NoahW314:monomial

Conversation

@NoahW314
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary f3dd886f91

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ monomial_sum_eq_prod

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 21, 2026
Copy link
Copy Markdown
Collaborator

@wwylele wwylele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the big operator version of MvPolynomial.monomial_mul, but the direction is flipped. I understand this code is following the same direction as MvPolynomial.monomial_sum_one, so there is tension in existing lemmas which doesn't need to be resolved in the PR. I don't have strong opinion on this. Just calling it out in case someone else think strongly about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants