Skip to content

feat(RingTheory/Localization, FieldTheory/Galois): refactor fraction field action API and add fixingSubgroup lemmas#38377

Open
xroblot wants to merge 3 commits intoleanprover-community:masterfrom
xroblot:igg_refactor
Open

feat(RingTheory/Localization, FieldTheory/Galois): refactor fraction field action API and add fixingSubgroup lemmas#38377
xroblot wants to merge 3 commits intoleanprover-community:masterfrom
xroblot:igg_refactor

Conversation

@xroblot
Copy link
Copy Markdown
Collaborator

@xroblot xroblot commented Apr 22, 2026

Extracts the components of the proof of IsGaloisGroup.to_isFractionRing, adding API for working with "Galois extensions of domains".

Also adds fixingSubgroup_range_algebraMap and its ring-domain analogue: if G is a Galois group for L/K and a subgroup H is a Galois group for L/R, then the elements of G fixing the range of algebraMap R L pointwise are exactly the elements of H.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 6a3c0a920a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ faithfulSMul
+ fixingSubgroup_range_algebraMap
+ fixingSubgroup_range_algebraMap_of_isDomain
+ isInvariant
+ mulSemiringAction
+ smulCommClass
+ smulDistribClass

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@riccardobrasca riccardobrasca self-assigned this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants