Skip to content

chore: golf using grind#38381

Open
euprunin wants to merge 2 commits intoleanprover-community:masterfrom
euprunin:golf-dcxlvi
Open

chore: golf using grind#38381
euprunin wants to merge 2 commits intoleanprover-community:masterfrom
euprunin:golf-dcxlvi

Conversation

@euprunin
Copy link
Copy Markdown
Contributor

The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (differences <30 ms considered measurement noise):

  • ✅️ SimpleGraph.Walk.takeUntil_eq_take: 258 ms before, 206 ms after 🎉

Profiled using set_option trace.profiler true in.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

PR summary 1a5bbc7d37

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-combinatorics Combinatorics label Apr 22, 2026
Comment thread Mathlib/Combinatorics/SimpleGraph/Walk/Decomp.lean Outdated
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 23, 2026

Seems sensible to me, can an expert check?
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants