Skip to content

chore: make algebraMap reducible#38430

Open
sgouezel wants to merge 3 commits intoleanprover-community:masterfrom
sgouezel:SG_alge
Open

chore: make algebraMap reducible#38430
sgouezel wants to merge 3 commits intoleanprover-community:masterfrom
sgouezel:SG_alge

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

PR summary 7de9521026

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- algebraMap

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 23, 2026
/-- Embedding `R →+* A` given by `Algebra` structure.
Use `algebraMap` from the root namespace instead. -/
protected algebraMap : R →+* A
/-- Embedding `R →+* A` given by `Algebra` structure. -/
Copy link
Copy Markdown
Collaborator

@wwylele wwylele Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious from the generated doc that this is available in the root namespaceexport, or we should mention it in the doc string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants