Skip to content

fix(scripts/rm_set_option.py): make more usable in downstream projects#38532

Open
bryangingechen wants to merge 3 commits intoleanprover-community:masterfrom
bryangingechen:rm_set_option_downstream_fix
Open

fix(scripts/rm_set_option.py): make more usable in downstream projects#38532
bryangingechen wants to merge 3 commits intoleanprover-community:masterfrom
bryangingechen:rm_set_option_downstream_fix

Conversation

@bryangingechen
Copy link
Copy Markdown
Contributor

Two changes:

  • Only attempt to process lakefile.lean if it exists.
  • Added a new --directories command-line option to specify which directories to scan (copied from dag_traversal.py, and passed directly to that script).

cf. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/backward.2EisDefEq.2ErespectTransparency/near/590911742


@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026

PR summary 2113b17760

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the CI Modifies the continuous integration setup or other automation label Apr 25, 2026
Comment thread scripts/rm_set_option.py Outdated
Comment thread scripts/rm_set_option.py Outdated
bryangingechen and others added 2 commits April 25, 2026 19:47
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
@grunweg grunweg changed the title fix(scripts/ rm_set_option.py): make more usable in downstream projects fix(scripts/rm_set_option.py): make more usable in downstream projects Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants