feat(Topology): some lemmas about topological bases#38538
Open
CoolRmal wants to merge 3 commits intoleanprover-community:masterfrom
Open
feat(Topology): some lemmas about topological bases#38538CoolRmal wants to merge 3 commits intoleanprover-community:masterfrom
CoolRmal wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
Contributor
CoolRmal
commented
Apr 26, 2026
PR summary 80a6231dcf
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Bases | 616 | 617 | +1 (+0.16%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.Bases Mathlib.Topology.UniformSpace.Ultra.Basic |
1 |
Declarations diff
+ IsTopologicalBasis.continuousOn_iff
+ exists_seq_basis
+ isTopologicalBasis_singleton_empty
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
CoolRmal
commented
Apr 26, 2026
| Continuous f ↔ ∀ s ∈ B, IsOpen (f ⁻¹' s) := by | ||
| rw [hB.eq_generateFrom, continuous_generateFrom_iff] | ||
|
|
||
| theorem IsTopologicalBasis.continuousOn_iff [TopologicalSpace β] |
Contributor
Author
There was a problem hiding this comment.
Not sure whether I should put this theorem in this file as it is the reason why I import Mathlib.Topology.ContinuousOn. I need to import Mathlib.Topology.Bases if I put this lemma in Mathlib.Topology.ContinuousOn.
4 tasks
wwylele
reviewed
Apr 26, 2026
Co-authored-by: Weiyi Wang <wwylele@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.