Skip to content

chore(Combinatorics/SimpleGraph): use the auto-param in loopless more#38554

Open
YaelDillies wants to merge 1 commit intoleanprover-community:masterfrom
YaelDillies:simple_graph_less_loopless
Open

chore(Combinatorics/SimpleGraph): use the auto-param in loopless more#38554
YaelDillies wants to merge 1 commit intoleanprover-community:masterfrom
YaelDillies:simple_graph_less_loopless

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary bf32ba391f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ covBy_irrefl

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@SnirBroshi
Copy link
Copy Markdown
Collaborator

SnirBroshi commented Apr 26, 2026

I believe this is already covered by #38092, and I prefer to avoid conflicts if possible

@YaelDillies
Copy link
Copy Markdown
Contributor Author

... except this change has nothing to do with the titular one of #38092 ? Did you scope-creep?

@SnirBroshi
Copy link
Copy Markdown
Collaborator

SnirBroshi commented Apr 26, 2026

No I don't believe I did, deprecating Symmetric requires changing all usages of the SimpleGraph constructor.

I could just as well call the change you did to edgeSet_subset_compl_diagSet here scope-creep, but I don't think there's anything wrong with it being here. (btw irrefl_def is probably what you're looking for)

@YaelDillies
Copy link
Copy Markdown
Contributor Author

If anything, I need the change here for a PR that makes a change concurrent to the titular one of #38092. Therefore it doesn't make sense for me to wait for #38092 to ve merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants