Skip to content

feat: use Is*Apply classes for continuous linear maps#38561

Draft
mcdoll wants to merge 31 commits intoleanprover-community:masterfrom
mcdoll:algebraic_funlike_clm
Draft

feat: use Is*Apply classes for continuous linear maps#38561
mcdoll wants to merge 31 commits intoleanprover-community:masterfrom
mcdoll:algebraic_funlike_clm

Conversation

@mcdoll
Copy link
Copy Markdown
Member

@mcdoll mcdoll commented Apr 27, 2026


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

PR summary 6382abce16

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
../mathlib-ci/scripts/pr_summary/import_trans_difference.sh all
There are 3749 files with changed transitive imports taking up over 172262 characters: this is too many to display!
You can run this locally from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci


Declarations diff

+ FunLike.instMonoidWithZero
+ FunLike.instRing
+ FunLike.instSemiring
+ IsAddApply
+ IsDivApply
+ IsInvApply
+ IsMulApply
+ IsMulApplyEqComp
+ IsNegApply
+ IsOneApply
+ IsOneApplyEqId
+ IsPowApply
+ IsSMulApply
+ IsSubApply
+ IsVAddApply
+ IsZeroApply
+ NormedSpace.toContinuousSMul
+ coeMulHom
+ coeMulHom_injective
+ coe_coeMulHom
+ coe_div
+ coe_intCast
+ coe_inv
+ coe_natCast
+ coe_one
+ coe_pow
+ div_apply
+ instAddApply
+ instCancelCommMonoid
+ instCancelMonoid
+ instCommGroup
+ instCommMonoid
+ instCommMonoidWithZero
+ instCommSemigroup
+ instDistribMulAction
+ instDistribSMul
+ instDivInvMonoid
+ instDivInvOneMonoid
+ instDivisionCommMonoid
+ instDivisionMonoid
+ instGroup
+ instInvOneClass
+ instInvolutiveInv
+ instIsAddApply
+ instIsCancelMul
+ instIsCentralScalar
+ instIsLeftCancelMul
+ instIsMulApplyEqComp
+ instIsOneApplyEqId
+ instIsRightCancelMul
+ instIsScalarTower
+ instIsZeroApply
+ instLeftCancelMonoid
+ instLeftCancelSemigroup
+ instModule
+ instMonoid
+ instMonoidWithZero
+ instMulAction
+ instMulOne
+ instMulZeroClass
+ instMulZeroOneClass
+ instRightCancelMonoid
+ instRightCancelSemigroup
+ instSMulCommClass
+ instSemigroup
+ instSemigroupWithZero
+ instZeroApply
+ inv_apply
+ mul_apply_eq_comp
+ one_apply_eq_id
+ pow_apply
+ prod_apply
++ instIsNegApply
++ instIsSMulApply
++ instIsSubApply
+++-- smul_apply
++- mul_apply
++- one_apply
++-- add_apply
++-- coe_zero
++-- neg_apply
++-- sub_apply
++-- sum_apply
+-+ coe_mul
+-+ coe_smul
+-+ intCast_apply
+-+ natCast_apply
- addCommGroup
- addCommMonoid
- instNatCast
- instance : AddMonoid (M₁ →SL[σ₁₂] M₂)
- isScalarTower
- mulAction
- ring
- semiring
- smulCommClass

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.17)
Current number Change Type
6 1 maxHeartBeats modifications

Current commit 65e3b6d6e4
Reference commit 6382abce16

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 27, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant