Skip to content

perf(Polynomial/HasseDeriv): explicit type annotations for compHom#38580

Draft
mcdoll wants to merge 5 commits intoleanprover-community:masterfrom
mcdoll:perf_hasse
Draft

perf(Polynomial/HasseDeriv): explicit type annotations for compHom#38580
mcdoll wants to merge 5 commits intoleanprover-community:masterfrom
mcdoll:perf_hasse

Conversation

@mcdoll
Copy link
Copy Markdown
Member

@mcdoll mcdoll commented Apr 27, 2026


Open in Gitpod

@github-actions github-actions Bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc) labels Apr 27, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 27, 2026
Comment thread Mathlib/Algebra/Polynomial/HasseDeriv.lean Outdated
@mcdoll
Copy link
Copy Markdown
Member Author

mcdoll commented Apr 27, 2026

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 27, 2026

Benchmark results for 0c7bbc2 against 7e1d43c are in. No significant results found. @mcdoll

  • build//instructions: -18.7G (-0.01%)

Small changes (3✅)

  • build/module/Mathlib.Algebra.Ring.Action.Rat//instructions: -501.7M (-10.10%)
  • build/module/Mathlib.Lean.ContextInfo//instructions: -126.3M (-3.86%) (reduced significance based on absolute threshold)
  • build/module/Mathlib.Tactic.Change//instructions: -126.6M (-4.08%)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

PR summary 6382abce16

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants