refactor(Analysis): golf Mathlib/Analysis/Normed/Unbundled/SpectralNorm#38646
Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Open
refactor(Analysis): golf Mathlib/Analysis/Normed/Unbundled/SpectralNorm#38646yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Mathlib/Analysis/Normed/Unbundled/SpectralNorm#38646yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
28 tasks
PR summary 900c9b0390Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 14 | 1 | backward.inferInstanceAs.wrap.data |
Current commit 7f61de83bf
Reference commit 900c9b0390
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
|
Collaborator
Author
|
!bench |
|
Benchmark results for 7f61de8 against 900c9b0 are in. No significant results found. @yuanyi-350
Small changes (1🟥)
|
| /-- If `K` is a field complete with respect to a nontrivial nonarchimedean multiplicative norm and | ||
| `L/K` is an algebraic extension, then any power-multiplicative `K`-algebra norm on `L` coincides | ||
| with the spectral norm. -/ | ||
| theorem spectralNorm_unique [CompleteSpace K] {f : AlgebraNorm K L} (hf_pm : IsPowMul f) : |
Collaborator
There was a problem hiding this comment.
I think you should revert all changes for this theorem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spectralValue_eq_zero_iffviaeq_X_pow_iff_natDegree_le_natTrailingDegreeandspectralValueTerms_of_lt_natDegreespectralNorm.eq_of_normalClosure'as two applications ofspectralNorm.eq_of_towerspectralNorm_uniqueby switching the local transported structures toset/letI/haveIwithinferInstanceAsExtracted from #37968