Skip to content

[Merged by Bors] - feat(NumberTheory.Height.Northcott): lemmas on compositions#38648

Closed
MichaelStollBayreuth wants to merge 2 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_Northcott_1
Closed

[Merged by Bors] - feat(NumberTheory.Height.Northcott): lemmas on compositions#38648
MichaelStollBayreuth wants to merge 2 commits intoleanprover-community:masterfrom
MichaelStollBayreuth:MS_Northcott_1

Conversation

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

@MichaelStollBayreuth MichaelStollBayreuth commented Apr 28, 2026

This adds two lemmas to Mathlib.NumberTheory.Height.Northcott:

  • Northcott.lemma comp_of_bddAbove: the post-composition of a Northcott function with a function that pulls back bounded above sets to bounded above sets is Northcott
  • Northcott.comp_of_finite_fibers: the pre-composition of a Northcott function with a function that has finite fibers is Northcott.

They will be useful in the context of heights.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

PR summary 900c9b0390

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comp_of_bddAbove
+ comp_of_finite_fibers
+ exists_min_image
- Northcott.exists_min_image

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Apr 28, 2026
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by tb65536.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 28, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 28, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
This adds two lemmas to Mathlib.NumberTheory.Height.Northcott:
* `Northcott.lemma comp_of_bddAbove`: the post-composition of a Northcott function with a function that pulls back bounded above sets to bounded above sets is Northcott
* `Northcott.comp_of_finite_fibers`: the pre-composition of a Northcott function with a function that has finite fibers is Northcott.

They will be useful in the context of heights.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 28, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(NumberTheory.Height.Northcott): lemmas on compositions [Merged by Bors] - feat(NumberTheory.Height.Northcott): lemmas on compositions Apr 28, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants