feat(RingTheory.DedekindDomain.Factorization): add API for factorization#38654
Open
MichaelStollBayreuth wants to merge 6 commits intoleanprover-community:masterfrom
Open
feat(RingTheory.DedekindDomain.Factorization): add API for factorization#38654MichaelStollBayreuth wants to merge 6 commits intoleanprover-community:masterfrom
MichaelStollBayreuth wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
PR summary 900c9b0390
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.DedekindDomain.Factorization | 2126 | 2127 | +1 (+0.05%) |
Import changes for all files
| Files | Import difference |
|---|---|
19 filesMathlib.Algebra.Module.Torsion.PrimaryComponent Mathlib.AlgebraicGeometry.EllipticCurve.LFunction Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.Height.NumberField Mathlib.NumberTheory.NumberField.AdeleRing Mathlib.NumberTheory.NumberField.Completion.FinitePlace Mathlib.NumberTheory.NumberField.Cyclotomic.Basic Mathlib.NumberTheory.NumberField.Cyclotomic.Galois Mathlib.NumberTheory.NumberField.Cyclotomic.Ideal Mathlib.NumberTheory.NumberField.Cyclotomic.PID Mathlib.NumberTheory.NumberField.Cyclotomic.Three Mathlib.NumberTheory.NumberField.Discriminant.Different Mathlib.NumberTheory.NumberField.FinitePlaces Mathlib.NumberTheory.NumberField.Ideal.Basic Mathlib.NumberTheory.NumberField.ProductFormula Mathlib.RingTheory.DedekindDomain.Factorization Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing Mathlib.RingTheory.Ideal.Norm.RelNorm Mathlib.Topology.Algebra.Ring.Compact |
1 |
Declarations diff
+ Ideal.finprod_heightOneSpectrum_pow_multiplicity
+ count_normalizedFactors_eq_multiplicity
+ emultiplicity_ciSup
+ emultiplicity_sup
+ factorization_eq_multiplicity
+ maxPowDividing_eq_pow_multiplicity
+ multiplicity_ciSup
+ multiplicity_le_of_ideal_ge
+ multiplicity_sup
+ normalizedFactors_prod_inter_eq_inter
+ prod_inter_normalizedFactors_ne_zero
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to technical debt.
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
simplemmas that convert ways of expressing the multiplicity of a prime idealpin the factorization of an idealIintomultiplicity p.asIdeal I(see #Is there code for X? > Results on elements of number fields and ideals @ 💬),multiplicity p.asIdeal I.These will be useful in proving the Northcott property of heights on number fields.