feat(LinearAlgebra/AffineSpace/AffineSubspace): using AffineSubspace.direction to reinterpret AffineSubspace as Submodule#38731
Conversation
PR summary 672768680fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
One thing I just realized: isn't this just a specialization of Edit: and we can add a lemma that |
wwylele
left a comment
There was a problem hiding this comment.
Don't forget to update PR title and description
AffineSubspace to SubmoduleAffineSubspace.direction to reinterpret AffineSubspace as Submodule
AffineSubspace.vsub_self_of_zero_memthat statess -ᵥ s = sif0 ∈ sAffineSubspace.direction_eq_self_of_zero_memthat states that if0 ∈ s, then the directions coerce back to the affine subspace.CanLiftinstance.AffineSubspace.directionto state that this can be used for reinterpretation of an affine subspace as a submodule.Coeinstance based onSubmodule.toAffineSubspaceand adds corresponding @[coe] attribute.The PR also performs a slight cleanup of the file: statements about
SetLikeorSubmodule.toAffineSubspacehave been moved closer to their respective definitions.