Skip to content

feat: DirSupClosedOn on linear orders#38809

Open
vihdzp wants to merge 1 commit intoleanprover-community:masterfrom
vihdzp:linord
Open

feat: DirSupClosedOn on linear orders#38809
vihdzp wants to merge 1 commit intoleanprover-community:masterfrom
vihdzp:linord

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented May 1, 2026

Every subset of a linear order is directed, so we can take off this part of the predicate.


Open in Gitpod

@vihdzp vihdzp requested a review from b-mehta May 1, 2026 15:45
@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory labels May 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

PR summary 177caf0bcc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ dirSupClosedOn_iff_of_linearOrder
+ dirSupClosed_iff_of_linearOrder
+ dirSupInaccOn_iff_of_linearOrder
+ dirSupInacc_iff_of_linearOrder
+ directedOn_of_linearOrder

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant