Skip to content

feat(PresentedGroup): free-product of presentations is isomorphic to the presentation of the union (over the disjoint union of generators)#38866

Open
j-mayoral wants to merge 5 commits intoleanprover-community:masterfrom
j-mayoral:PresentedGroup.coprodPresentations
Open

feat(PresentedGroup): free-product of presentations is isomorphic to the presentation of the union (over the disjoint union of generators)#38866
j-mayoral wants to merge 5 commits intoleanprover-community:masterfrom
j-mayoral:PresentedGroup.coprodPresentations

Conversation

@j-mayoral
Copy link
Copy Markdown
Contributor


Adds the theorem that the free product of presentations is isomorphic to the presentation on the disjoint union of the generators with the union of the relations. That is,
<α | R₁> * <β | R₂> ≃* <α ⊕ β | iα(R₁) ∪ iβ(R₂)>.

Don't know if the current file is the best to add this result.

I have the feeling this could be made more elegant, avoiding the need to state lemmas explicitly about the relations of the canonical maps, by instead working with relations on the free product of free groups and then studying how quotienting by relations behaves in terms of isomorphisms. However, that approach is less straightforward, so I prefer to keep the current PR as is and discuss possible refinements there to get better feedback (I’m new and still learning).

Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label May 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label May 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

PR summary 60ff4cd38c

Import changes exceeding 2%

% File
+15.63% Mathlib.GroupTheory.PresentedGroup

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.GroupTheory.PresentedGroup 467 540 +73 (+15.63%)
Import changes for all files
Files Import difference
3 files Mathlib.GroupTheory.Coxeter.Basic Mathlib.GroupTheory.Coxeter.Inversion Mathlib.GroupTheory.Coxeter.Length
2
Mathlib.GroupTheory.PresentedGroup 73

Declarations diff

+ coprodOf
+ coprodOf_kills_rels
+ coprodPresentations
+ lift_coprodOf_inl_eq_inl_mk
+ lift_coprodOf_inr_eq_inr_mk
+ lift_of_eq_mk_map
+ map_in_rels_eq_one

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-group-theory Group theory label May 3, 2026
@j-mayoral j-mayoral marked this pull request as ready for review May 3, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant