Skip to content

refactor(MeasureTheory): golf Mathlib/MeasureTheory/Covering/Besicovitch#38875

Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:M_11
Open

refactor(MeasureTheory): golf Mathlib/MeasureTheory/Covering/Besicovitch#38875
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:M_11

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • shortens the proof of r_t0 in exists_closedBall_covering_tsum_measure_le by turning the contradiction argument into a direct lambda
  • replaces the manual simp only proof with mem_iUnion₂ and a final simp [r, this]

Extracted from #38104

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels May 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

PR summary 2fbf21f9b5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label May 3, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • exists_closedBall_covering_tsum_measure_le: 1.530226 -> 1.608270 (+5.10%)

Overall:

  • All changed declarations are slower.

@yuanyi-350 yuanyi-350 requested a review from jcommelin May 3, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant