Skip to content

feat(GroupTheory/Perm/Fin): Add (cycleIcc i j) ∘ j.succAbove = i.succAbove for i ≤ j#39170

Open
yuanyi-350 wants to merge 2 commits into
leanprover-community:masterfrom
yuanyi-350:G_2
Open

feat(GroupTheory/Perm/Fin): Add (cycleIcc i j) ∘ j.succAbove = i.succAbove for i ≤ j#39170
yuanyi-350 wants to merge 2 commits into
leanprover-community:masterfrom
yuanyi-350:G_2

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • proves (cycleIcc i j) ∘ j.succAbove = i.succAbove for i ≤ j, giving the expected succAbove compatibility for cycleIcc

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly and removed codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels May 11, 2026
@github-actions github-actions Bot added the t-group-theory Group theory label May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

PR summary bda55fe31c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cycleIcc_comp_succAbove

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Comment thread Mathlib/GroupTheory/Perm/Fin.lean Outdated
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
@yuanyi-350 yuanyi-350 requested a review from robin-carlier May 11, 2026 14:51
Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants