Skip to content

refactor(Analysis): golf Mathlib/Analysis/Complex/ValueDistribution/LogCounting/Asymptotic#39171

Open
yuanyi-350 wants to merge 2 commits into
leanprover-community:masterfrom
yuanyi-350:A_13
Open

refactor(Analysis): golf Mathlib/Analysis/Complex/ValueDistribution/LogCounting/Asymptotic#39171
yuanyi-350 wants to merge 2 commits into
leanprover-community:masterfrom
yuanyi-350:A_13

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • shortens one_isLittleO_logCounting_single by deriving it from a theta estimate for log r - log ‖e‖
  • shortens logCounting_isBigO_one_iff_analyticOnNhd by reusing divisor_nonneg_iff_analyticOnNhd directly

Extracted from #37968

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels May 11, 2026
@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

PR summary 48f66c0814

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • one_isLittleO_logCounting_single: 0.203687 -> 0.032370 (-84.1%)
  • logCounting_isBigO_one_iff_analyticOnNhd: 0.420270 -> 0.051027 (-87.9%)

Overall:

  • both proofs got substantially faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant