Skip to content

refactor(MeasureTheory): golf Mathlib/MeasureTheory/Measure/PreVariation#39178

Open
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:M_30
Open

refactor(MeasureTheory): golf Mathlib/MeasureTheory/Measure/PreVariation#39178
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:M_30

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • refactors Mathlib/MeasureTheory/Measure/PreVariation by simplifying sum_le' and sum_le_preVariationFun_of_subset

Extracted from #38104

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels May 11, 2026
@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label May 11, 2026
@github-actions
Copy link
Copy Markdown

PR summary 48f66c0814

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • sum_le': 0.503895 -> 0.130258 (-74.15%)
  • sum_le_preVariationFun_of_subset: 0.119698 -> 0.044800 (-62.57%)

Overall:

  • all compared declarations sped up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant