feat(fun_prop): allow fun_prop to call discharger on ModelWithCorners#39226
Open
lecopivo wants to merge 3 commits into
Open
feat(fun_prop): allow fun_prop to call discharger on ModelWithCorners#39226lecopivo wants to merge 3 commits into
lecopivo wants to merge 3 commits into
Conversation
PR summary 5f3d49483eImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
|
As we discussed in person: thanks a lot, this is great! Please add the test you created locally, once your local build has worked. (I should also make a prototype branch to hack in ContMDiff support; that's one me.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a discharger in
fun_propis allowed to be run only onProp-valued hypothesis.This PR allows to execute dischargers also on
ModelWithCorners. This will enablefun_propto supportContMDiffproperly: lemmas likeContMDiff.comprequire inferring the model with corners on the intermediate space. This PR is thus required to properly support manifolds infun_prop; a future PR will implement this.In the future, we might want to allow discharger to execute on other Type-valued hypothesis.
In this case, we could create an environment extension to register such types.
However, right now we could not think of any other use cases --- therefore, we hard-coded
ModelWithCorners.