Skip to content

chore(LinearAlgebra/Ray): remove a defeq abuse#39477

Open
wwylele wants to merge 1 commit into
leanprover-community:masterfrom
wwylele:defeq-abuse-ray
Open

chore(LinearAlgebra/Ray): remove a defeq abuse#39477
wwylele wants to merge 1 commit into
leanprover-community:masterfrom
wwylele:defeq-abuse-ray

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented May 16, 2026

Previously, the code uses Subtype constructor to construct RayVector, and the instance cannot see through this. As a common practice, RayVector declares its own constructor to resolve this


Open in Gitpod

Previously, the code uses Subtype constructor to construct RayVector, and the instance cannot see through this. As a common practice, RayVector declares its own constructor to resolve this
@wwylele wwylele added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label May 16, 2026
@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 16, 2026
@github-actions
Copy link
Copy Markdown

PR summary 1bac7ff38c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ RayVector.coe_mk
+ RayVector.ext
+ RayVector.mk

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant