Skip to content

feat: add and use custom (d)elaborators for mvfderiv, add basic API lemmas#39554

Open
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:mvfderiv-delab-api
Open

feat: add and use custom (d)elaborators for mvfderiv, add basic API lemmas#39554
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:mvfderiv-delab-api

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented May 18, 2026

Add a custom elaborator (scoped to the Manifold namespace) shortening mvfderiv I f to d% f,
and have a corresponding delaborator also. Their implementation is fully analogous to the existing elaborators.

Also, rewrite Lie bracket lemmas to use mvfderiv instead of open-coding it.

Part of #36036, i.e. from the path towards the Levi-Civita connection and Riemanian curvature.
Related to fixing defeq abuses related to tangent space and scalar multiplication in mathlib.

Co-authored-by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com
Co-authored-by: Patrick Massot patrickmassot@free.fr


Open in Gitpod

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented May 18, 2026

This code was virtually all written by Patrick; I just made minor clean-ups (such as updating the module doc-string, or switching the notation to d% as discussed with Patrick and Heather). Before my clean-ups, I would have been happy to merge this PR directly. Given this, let's have another pair of eyes for good measure:
maintainer merge?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

PR summary c481c5c698

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mvfderiv_const
+ mvfderiv_mul
+ mvfderiv_neg
+ mvfderiv_smul
+ mvfderiv_sub
- extDerivFun
- extDerivFun_add
- extDerivFun_zero

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-differential-geometry Manifolds etc label May 18, 2026
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 18, 2026
Also, rewrite Lie bracket lemmas to use mvfderiv instead of open-coding it.
@grunweg grunweg force-pushed the mvfderiv-delab-api branch from 52739fc to c481c5c Compare May 18, 2026 21:50
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@grunweg grunweg mentioned this pull request May 18, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant