Skip to content

feat(Data/Finset/Prod): add Equiv.Finset.prod#39559

Open
b-mehta wants to merge 1 commit into
leanprover-community:masterfrom
b-mehta:feat/finset-product-equiv-prod
Open

feat(Data/Finset/Prod): add Equiv.Finset.prod#39559
b-mehta wants to merge 1 commit into
leanprover-community:masterfrom
b-mehta:feat/finset-product-equiv-prod

Conversation

@b-mehta
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta commented May 18, 2026

The choice of simp lemmas and simps setup is chosen here to match Equiv.Set.prod, for consistency.


Open in Gitpod

@b-mehta b-mehta added the easy < 20s of review time. See the lifecycle page for guidelines. label May 18, 2026
@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label May 18, 2026
@github-actions
Copy link
Copy Markdown

PR summary 4cd4643e0d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Equiv.Finset.prod

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@wwylele
Copy link
Copy Markdown
Collaborator

wwylele commented May 18, 2026

The choice of simp lemmas and simps setup is chosen here to match Equiv.Set.prod, for consistency.

Did you forget to add @[simp(s)]?

@b-mehta
Copy link
Copy Markdown
Contributor Author

b-mehta commented May 19, 2026

Nope, precisely because Equiv.Set.prod doesn't either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants