Skip to content

[Merged by Bors] - feat(Valued/WithVal): missing rfl lemmas for field operations#39563

Closed
eric-wieser wants to merge 2 commits into
leanprover-community:masterfrom
eric-wieser:missing-val-lemmas
Closed

[Merged by Bors] - feat(Valued/WithVal): missing rfl lemmas for field operations#39563
eric-wieser wants to merge 2 commits into
leanprover-community:masterfrom
eric-wieser:missing-val-lemmas

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented May 19, 2026

This adds the missing lemmas for (nat|int|nnrat|rat)Cast, zpow, and ofNat.

These were found while attempting a refactor to use Function.Injective.field in #39562.


Open in Gitpod

This adds the missing lemmas for `(nat|int|nnrat|rat)Cast`, `zpow`, and `ofNat`.
@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label May 19, 2026
@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label May 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

PR summary bf95470997

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ofVal_intCast
+ ofVal_natCast
+ ofVal_nnratCast
+ ofVal_ofNat
+ ofVal_ratCast
+ ofVal_zpow
+ toVal_intCast
+ toVal_natCast
+ toVal_nnratCast
+ toVal_ofNat
+ toVal_ratCast
+ toVal_zpow

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@kbuzzard
Copy link
Copy Markdown
Member

Thanks!

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request May 19, 2026
This adds the missing lemmas for `(nat|int|nnrat|rat)Cast`, `zpow`, and `ofNat`.

These were found while attempting a refactor to use `Function.Injective.field` in #39562.
@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 19, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 19, 2026

Build failed:

Fix if necessary, and then someone with permission can run bors r+ or bors retry.

@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request May 19, 2026
This adds the missing lemmas for `(nat|int|nnrat|rat)Cast`, `zpow`, and `ofNat`.

These were found while attempting a refactor to use `Function.Injective.field` in #39562.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 19, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Valued/WithVal): missing rfl lemmas for field operations [Merged by Bors] - feat(Valued/WithVal): missing rfl lemmas for field operations May 19, 2026
@mathlib-bors mathlib-bors Bot closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants