refactor(NumberField/House): expose Siegel lemma infrastructure#39875
Open
mkaratarakis wants to merge 9 commits into
Open
refactor(NumberField/House): expose Siegel lemma infrastructure#39875mkaratarakis wants to merge 9 commits into
mkaratarakis wants to merge 9 commits into
Conversation
Introduce colon-ideal denominators for algebraic elements and the specialization to natural-number denominators over the integers. Co-authored-by: Cursor <cursoragent@cursor.com>
Add `IsIntegral.Cast` and `IsIntegral.Nat` for integer and natural literals in number fields, used when clearing denominators in transcendence arguments. Co-authored-by: Cursor <cursoragent@cursor.com>
Rename the basis-matrix bound to `basisMatrixInvSupNorm`, make `house` reducible, and adjust the Siegel nonvanishing vector API for downstream Gelfond-Schneider bounds. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
PR summary b36f973385Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
mkaratarakis
changed the title
3 tasks
mathlib-dependent-issues
Bot
added
the
blocked-by-other-PR
Contributor
github-actions
Bot
added
the
file-removed
github-actions
Bot
removed
the
file-removed
Contributor
Author
mathlib-dependent-issues
Bot
removed
the
blocked-by-other-PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose Siegel's lemma infrastructure in
NumberField.House: rename the privatebasis-matrix bound to
basisMatrixInvSupNorm, makehousereducible, andadjust
exists_ne_zero_int_vec_house_le.