chore(Geometry/Manifold): remove some @[expose] public section#39886
Open
grunweg wants to merge 5 commits into
Open
chore(Geometry/Manifold): remove some @[expose] public section#39886grunweg wants to merge 5 commits into
@[expose] public section#39886grunweg wants to merge 5 commits into
Conversation
The two results of note are the final two theorems: everything else is auxiliary towards that. We make the lemmas private, and hence do not need to expose the only (now-private) definition either.
grunweg
added
t-differential-geometry
PR summary 7cfa70637fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
All definitions in this file are constructions of singular n-manifolds. These really need their M field exposed (so we expose the entire definition). This is analogous to category theory, where definitional equalities at the object level are valuable.
There are just two definitions in this file; both have plenty of API. There does not seem to be a good reason to expose them
…is is useful" This reverts commit fea13c2.
grunweg
force-pushed
the
diffgeo-expose-less
branch
from
7f2d3c0 to
7cfa706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go through a few files and audit the exposed definitions there. Best reviewed commit by commit.
I'm happy to give more details on any file where desired.