Skip to content

[Merged by Bors] - chore: rename MonoidHom.injective_pi to pi_injective#40045

Closed
ADedecker wants to merge 1 commit into
leanprover-community:masterfrom
ADedecker:AD_monoidHom_pi_injective
Closed

[Merged by Bors] - chore: rename MonoidHom.injective_pi to pi_injective#40045
ADedecker wants to merge 1 commit into
leanprover-community:masterfrom
ADedecker:AD_monoidHom_pi_injective

Conversation

@ADedecker
Copy link
Copy Markdown
Member

I introduced this name just a few hours ago, but I just realized that our naming convention explicitly states that it should be pi_injective.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 2c3b4be399

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AddHom.injective_pi
+ AddMonoidHom.injective_pi
+ MonoidHom.pi_injective
+ MulHom.pi_injective
- MonoidHom.injective_pi
- MulHom.injective_pi

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 2c3b4be399
Reference commit e647009b14

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
    • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 30, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 30, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 30, 2026
I introduced this name just a few hours ago, but I just realized that our naming convention [explicitly states](https://leanprover-community.github.io/contribute/naming.html#predicates-as-suffixes) that it should be `pi_injective`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 30, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: rename MonoidHom.injective_pi to pi_injective [Merged by Bors] - chore: rename MonoidHom.injective_pi to pi_injective May 30, 2026
@mathlib-bors mathlib-bors Bot closed this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants