Skip to content

fix: more complete model finding for a given manifold in context#40075

Open
grunweg wants to merge 2 commits into
leanprover-community:masterfrom
grunweg:jacobian-elaborator-bug
Open

fix: more complete model finding for a given manifold in context#40075
grunweg wants to merge 2 commits into
leanprover-community:masterfrom
grunweg:jacobian-elaborator-bug

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented May 31, 2026

When searching for a model with corners on a manifold, also try finding a model which is not just a local assumption, but the trivial model on a normed space or a non-trivially normed field.

Minimised from an elaborator failure in Kevin Buzzard's Jacobian challenge.


Open in Gitpod

When searching for a model with corners on a manifold, also try finding
a model which is not just a local assumption, but the trivial model on a
normed space or a non-trivially normed field.

Minimised from Kevin Buzzard's Jacobian challenge.
@grunweg grunweg added t-meta Tactics, attributes or user commands t-differential-geometry Manifolds etc labels May 31, 2026
@grunweg grunweg requested a review from Vierkantor May 31, 2026 10:00
Comment thread Mathlib/Geometry/Manifold/Notation.lean Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

PR summary 5d35abfd30

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 5d35abfd30
Reference commit 971b90233b

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
    • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-differential-geometry Manifolds etc t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant