Skip to content

feat: a diffeomorphism induces a manifold structure#40202

Open
Bergschaf wants to merge 5 commits into
leanprover-community:masterfrom
Bergschaf:Manifold
Open

feat: a diffeomorphism induces a manifold structure#40202
Bergschaf wants to merge 5 commits into
leanprover-community:masterfrom
Bergschaf:Manifold

Conversation

@Bergschaf
Copy link
Copy Markdown
Collaborator


This PR adds the pullback of a ChartedSpace instance along a Homeomorphism. (Similar to IsLocalHomeomorph.chartedSpace but with better def-eqs (because there is no need to choose the inverse of the function in this case)).
Diffeomorph.isManifold proves that the pullback of the ChartedSpace of a manifold along a diffeomorphism is a manifold again.
I am quite new to this area of mathlib, so please excuse any obvious oversights on my part.
Please give me feedback if this definition is appropriate!

Open in Gitpod

@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 3, 2026
@Bergschaf Bergschaf marked this pull request as draft June 3, 2026 22:12
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Jun 3, 2026

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@Bergschaf Bergschaf marked this pull request as ready for review June 3, 2026 22:15
@Bergschaf Bergschaf marked this pull request as draft June 3, 2026 22:15
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Jun 3, 2026

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR summary 1e9e1fee3c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Homeomorph.chartedSpace
+ isManifold

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 1e9e1fee3c
Reference commit 1450d19e6f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Bergschaf Bergschaf marked this pull request as ready for review June 3, 2026 22:18
@Bergschaf Bergschaf temporarily deployed to cache-upload-forks June 3, 2026 22:27 — with GitHub Actions Inactive
@grunweg grunweg added the t-differential-geometry Manifolds etc label Jun 4, 2026
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jun 4, 2026

Thanks for your contribution; differential geometry definitely needs more helping hands!
This PR adds a new definition, but no API (lemmas about it, or even results convincing that this is the right definition). Can you say why you want to have this definition? Do you have any application in mind?

-/
@[implicit_reducible]
def isManifold (f : Diffeomorph I I M' M n)
(h : atlas H M' = {(f.toHomeomorph.transOpenPartialHomeomorph (chartAt H (f q))) | q : M'})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit of a strange condition and statement. (I would assume that makes it awkward to use in practice.) Why do you write it like this?
Is it that you want to write "let f be a diffeomorphism from M' to M", but that statement requires a charted space structure on M' to make sense?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more natural statement would be the following:
Let f be a homeomorphism from M' to M. Endow M' with the charted space structure (via pullback). Then M' is a manifold w.r.t. the same model with corners as M, and this smooth structure makes f a smooth map (and even a diffeomorphism).

@grunweg grunweg self-assigned this Jun 4, 2026
@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 4, 2026
@grunweg grunweg changed the title feat(Geometry/Manifold/Diffeomorph): A diffeomorphism induces a manifold feat: a diffeomorphism induces a manifold structure Jun 4, 2026
/-- Given a homeomorphism `f : M' ≃ₜ M`, endow `M'` with a `ChartedSpace` structure by pulling back
the `ChartedSpace` structure from `M`. -/
@[implicit_reducible]
def Homeomorph.chartedSpace {f : M' ≃ₜ M} : ChartedSpace H M' where
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that #39107 has the same construction, but re-using the version for local homeomorphisms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants